I still have the suitcases I bought in the 1990s. Makes no sense why travelers suddenly need new suitcases.
Depends on how often you use them.
I wear out a roll around suitcase about every 3 - 4 years. (And that’s not counting the damage that baggage handlers and TSA do to them.)