-- ... the state of Supreme Court decisions was that military service was in furtherance of the service at the behest of national interests and that covered births off shore for all citizenship purposes for military service. --
The question isn't citizenship. On the "plain citizenship" question, if either parent is a US citizen meeting US residency, etc. requirements, then statutes assign citizenship at birth. Military service is not required and has nothing to do with it.
If you have a SCOTUS case that differentiates US base as 14th amendment US soil, or that finds servicepeople are treated the same as diplomats, I'll change my opinion.
-- The actual logic that held that the children of people who were SERVING the national interest of the United States should not be handicapped by being made second class citizens in their political potential is unassailable. --
That "second hand citizen" line is a canard. It pops up often, but fact of the matter is that a naturilized citizen hass all the rights of one born a citizen, save for eligibility for the presidency.
Q
It's not a canard. There are classes of citizens. Some citizens have more rights than others. The Natural Born Citizen has the right to run for president which all other classes of US citizens do not have. Ergo, they are second class citizens.