Celibacy is what we call a discipline, as opposed to a dogma. In principle it can change, and there are exceptions even now. I don’t think it shoul or will ever change though. The article does a good job explaining the basics of it.
It is a sacrifice that the celibate priest makes. If he did not make it, — for example, he is of an Eastern rite, or is a married convert ordained under the “pastoral provision”, — he is still a priest all the same. Like any sacrificial giving it is no guarantee of anything, just like you say. But in our age especially it is a blessing to have a celibate priest minister to adolescents and, to that matter, adults, as it is a visible direct and complete example of sexual continence, that a married parent can be only in part.
If everyone were to become celibate what would that do to Christanity. It would literally die out. I think a married priests who serves as a role model to the young that they should wait until they are married is much more realistic. And to those who are married, that being faithful only to one wife is kepeing marriage as a sacrament. And to the parents, that placing God ahead of everything, including family, is the disicipline to follow.
You speak of self-sacrifice in celbiacy as if waiting, keeping and putting God first isn't. Like everything else we don't go around announcing that we are fasting so that others may see how devout we are. This is something between us and God. It should not be the subject of public admiration.