Yes he had a long service record and went through very trying times as a POW. However he has been a terrible Senator, he gets worse every year.
Let's expand a bit on that little 'hero' factoid that the McCainiacs toss around...
The fact is, McCain, by his own admission, was 'broken' by torture while held prisoner by the Communists in North Vietnam. His own psychological fitness to hold ANY office is questionable, based upon his own behavior and conduct which on many occasions has been less than stable.
McCain went out of his way to figuratively and *literally* embrace his former Communist captors in working tirelessly to shut down any and all inquiries into the issue of MIAs and POWs unaccounted for and possibly held by Hanoi. He treated MIA-POW families with contempt, while he had only kind words and gestures for the North Vietnamese Commies:
The fact is, any good that McCain may have done during his military service has been UNdone in the years following, specifically once he attained elective office.
Even Benedict Arnold was hailed as a hero before he revealed his true colors as a turncoat. Even a casual student of history ought to understand that.