My brother-in-law has been going through the legal pathways to legal citizenship since 1999. He's completely aware of the long, arduous process. His greencard is good for 18 months while he waits for his legal citizenship papers to go through the government bureaucracy.
Your brother in law is to be commended.