“Recovering Catholic” is a term used by moral light-weights to proclaim the reason for their bad behavior; usually they blame their parenting as well. You hear it used often at AA meetings by participants not willing to take responsibility for their shortcomings. When I hear someone calling him/hersef that, I customarily walk out and find another meeting.
I like your definition....I know a guy who calls himself a recovering Catholic......he is living in sin and mocking the faith of his ancestors. Very sad for him.