Define "successful". I would give that honor to the M-1 Garand, in terms of numbers built/issued and enemy killed, but that's IMHO. (and I've never even fired one!)
Longest period of (US) military service - the M16 has been "in uniform" longer than any previously issued rifle.