2) Since so many states now have “right to carry” laws I would think that these states at least would honor permits by other states. And you would be right. But there's no reason to just "think that" if you're going to discuss the matter. The National Rifle Association (www.nra.org) among others gives good information about which states honor which other states' concealed weapon permits.
3) It wouldn’t help much in NY or places like that but you’d be good in most states. Pro-criminal states like NY, MD, IL don't recognize other states' concealed weapon permits. Every state that has "shall issue" permitting recognizes at least some other states' permits, often by mutual agreement. Again, look it up.
4) To drive a car on a public road is not a right protected by the Constitution. To bear arms IS such a right. That's the only reason I would tolerate the feds getting involved in the matter.
So it passes and you decide to carry concealed in New York or Chicago, and survive a stop by the police.
What are the chances you’ll end up charged with some crime which will result in loss of your right to possess a firearm let alone carry it concealed.
The intent is good, but I dont think this law will work in practice.