What New York is doing makes a lot more sense. This sound like someone promoted Eric Cartman to security chief.
I believe the consitutionality of traffic stops has been upheld because I would imagine in balance the benefit outweighs the cost. There is no probable cause there. Where is the line drawn at having to provide evidence (documents)of who you are, in some cases??
If you're traveling through a federal center, I don't have a problem with a requirement for ID.