Long-term, I'm very bullish on lunar mining.
That being said, an overly rosy view of this situation is apt to backfire. Short-term problems I see:
No shuttle fleet in operation
No Moon Base
No workable railgun technology to return rocks to Earth
No workable fusion reactors on Earth, once the rocks get here.
In short: we can't get there, we can't mine the stuff, we can't get the stuff back here, and we can't use the stuff if we do get it. So, Long-term, this will be great, and we have to begin work now so that we can eventually solve the problems and reap the benefits. But this is not just around the corner, IMO.
No shuttle fleet in operation Well, this one at least isn't a problem - the space shuttle is useless for getting to the Moon, as it's limited to low Earth orbit.