For years, I kept all my photos on hard drives inside my house. I had three large drives and would rotate them. I always hated having to plug them in and run the backup software.
I then tried using an Apple Network Attached Drive (their “Time Capsule”) with the Apple “Time Machine” software. It worked pretty good and quietly backed up my computer to my personal cloud in my house. But the Time Capsules were notoriously unreliable and Apple discontinued it.
I tried backing up to my home Synology NAS, but that didn’t work very well, either.
So I went with Apple’s iCloud. Apple takes security a lot more seriously (IMO) than Amazon and Google and is a lot more trustworthy. But my photos are in their cloud and subject to loss. I sometimes move all the photos down to my local storage, but I’ve gotten lax about that. But overall, I love the convenience of iCloud and the seamlessness between my phone, tablet and laptop. A pic snapped my phone is in the cloud in seconds (usually).
Of course, my first few thousand photographs were on Kodachrome and Ektachrome starting in 1973 and I’ve still got those slide. They are all digitized, too.
I had the same situation, starting in 1972. Then I took a hard-line approach and just tossed anything I hadn't viewed recently. I figured that if I wasn't interested in that stuff, who would?
I will never trust those corporate entities for any reason.