I don’t know why the father thought the chocolate could last four years. Of course, he didn’t know when the war was going to be over. But from past experience, Christmas chocolate, unless frozen, better be eaten within about six months.
I think the chocolate had symbolic significance more than anything else. It was a symbol of hope, and that there would be something after the war. Maybe it was more valuable as that, then if they had just eaten it anyway.