BooBoo, you are of course, entitled to your opinion.
However, I bet you would find that a large number of military pilots, air crew, and technicians were inspired to achieve their goal after they saw the Blue Angels or the Thunderbirds at an airshow when they were just kids.
It remains that these flight demonstration teams are effective recruiting tools.
Money well-spent?
I think so.
Several of my students have gone into naval, marine and air force aviation, and the demonstration teams have had a significant impression on these wonderful young men at an early age.
Since the Blues and the Thunderbirds are booked years in advance, I wouldn't have a problem with fielding even more forms of demonstration teams, such as attack helicopters, etc.