Loans by Israel have always been repaid. What's more, it is due to these loans that American jobs are created.
Not to suggest it costs us nothing, but military aid to Israel is required to be spent in the US on US-manufactured goods.