As to Israel is fully capable of buying American weapons with their own money, Israel wouldn't need to buy much of what they purchase from the US, they could produce them. And could export arms without US permission. It's a symbiotic relationship not common with most countries to whom we provide aid.
BTW eliminating all foreign aid, whether good or bad, wouldn't make a dent in our financial problems, current or future. Six or seven percent of our defense budget, which isn't enough. And that's not where the funds would go anyway.
You are correct, eliminating foreign aid doesn’t make a dent. It’s a small percentage of our budget. But we need to save a percent here and percent there. We need to cut a good 75% of non-military federal government. Quite honestly, if we changed the direction in which our military is pointing and focused on the defense of America, we could cut a huge portion of military spending.
Look at the leaps in government spending. COVID created a $1.5 to $2 Trillion per year increase in spending. COVID is over, but spending has not been cut back to 2019 levels - even then we needed to cut huge amounts of spending. Look at what we spent on the military before the “War on Terror”. Same idea. There’s one thing important to point out. No problem was solved by the COVID spending. We still have a potential terrorist problem. It’s called immigration. All of the 9/11 terrorists should never had been allowed to travel to America. That simple problem has never been solved. Instead we blew trillions on wars that we lost.
Bottom line, we become financially strong by focusing on the real problems and cutting what we really cannot afford. You might do that in your own household. I know I have. No cable. No Netflix. Cheaper phones. Slower Internet. Few long trips. Less expensive food choices. Slightly warmer AC temperatures. Slightly cooler heating temperatures. It ads up. No debt and I will buy a new car in a couple of months with cash. The important things in my life - family and friends - have remained the same. It can work the same way with nations.