I think it was too risky for Trump to have done this. The Democrats could have said yes to making 1.8 million illegals citizens, and pretended that they would fund security and the wall in the future. They did that with border security for the 1986 amnesty bill.
Trump knows when people actually want a deal vs posturing on an issue. The Dems are posturing, and he just called their bluff. He'll now mention in the SOTU how he wants to work with the Dems to get things done, but they want an election issue and not a solution. Now Trump can run out the DACA clock and blow all the illegals out of the country.