“If one has ‘paid their debt to society’, shouldn’t all of their Constitutional rights (including 2A) be restored?”
I tend to favor treating this as a package deal. I say wait ten years from the date of completed sentence and if they have stayed out of trouble then restore their civil rights. But I would also make an exception for persons convicted of violent felonies. Those would be barred for life from both voting and gun ownership.
A reasonable approach.