I visited Barcelona in 2012. There was a protest in one of the squares. Lots of shouting; but no violence. Interesting enough, no Catalan flags but several Communist flags.
The other thing is that every Thursday, the taxi drivers in Barcelona go on strike, it’s a real problem for tourists if they aren’t prepared.
Fortunately, we used the Hop-On/Hop-Off busses to get around.