Until she retires, never. She may have all the opinions she wants. As a justice, she is supposed to remain politically aloof in her decisions and pronouncements.
I agree, her political views and desires should have been kept to herself...but good to know how she feels about Trump. This will effectively shut her down should anything go to the Supreme Court which could negatively affect Trump, as she would have to recuse herself as everyone is stating. Justice Ginsberg now acknowledges she was out of line with her apology, so hopefully Trump will lay off as anything he says now will be like kicking a dog when its down.