Screw them. He should never release the tax returns.
I agree there is no up side to releasing the returns, which would be many thousands of pages. It would be used as ammunition against him regardless of whether he released them or not. Trump could say to Hillary, I will release my tax returns if you release the transcripts of your speeches to Goldman Sachs. Or touch on sealed documents involving some of the other Clinton scandals.