A hero is somepne who knows that he’s going into a situation where he may be killed, but he does it anyway, because it’s the right thing to do.
John McCain qualifies, because he flew missions over enemy territory and got shot at.
I salute his status as a hero, but I would not vote for the man, because his political values are contrary to my own.
Trump, on the other hand, is not a hero, but I share his political values and will probably vote for him.
I am a combat veteran.
I'm sorry but your logic is faulty. He flew missions over enemy territory, but that was his job. He did his job. If he had shot down three enemy planes and saved the lives of fellow aviators, at great risk to himself, he would be a hero. But he couldn't even eject from his crippled plane as he had been trained. What a dufus.