The sin of Onan was that he disobeyed God's command to procreate if memory serves. He spilled his seed on the ground to prevent procreation. It was not the act itself that was wrong, it was the intention behind the act. Trying to build a logical bridge between this and contreceptives is akin to trying to build that famous bridge to the 21st century.
Contraceptives are not intrinsically evil. I'm not buying your argument.
Err, if use of contraceptives isn't a person trying to prevent procreation, what is? Now, if you're using a drug with contraceptive side effects to treat an illness, that's different. I do feel the person is morally obligated to abstain from relations while on said drug, however, because of the possible abortive effects contraceptives possess.
In other words, if a man or woman is recieving a treatment for, say, cancer that renders them sterile, there is no moral problem with them carrying on relations within marriage as there is no possiblity of conception or abortion, and the effect is the unintended consequence of a life or death decision. On the other hand, if a woman is taking the Pill as a remedy for unusually heavy menstruation (hopefully after being very sure it won't mask symptoms of a greater problem), she should abstain from relations as there is still the possibility of conceiving while on the drug, and the resultant fetus being aborted due to the unhospitable environment birth control creates in the womb.
That's a stretch, and an example of the problem with Sola Scriptura. How could every Christian denomination have been wrong until 1929? What happened? Could rationalization have been involved?
More on Onanism/Birth Control