Upside: Professional people doing an important job for protecting our shores. The enemy is already here and must be found and neutralized.
Downside The potential for abuse by the next Clinton-type to be elected is truly frightening. It's easy for the unscrupulous (or the merely arrogant) to redefine enemies to be anyone they don't like.
We need an internal security agency. We don't need a Stasi.