The cathedral of the catholic diocese in my area also has a gift shop. It never occurred to me how that might be problematic.
It might depend on what they sell.
Ive visited almost all of the missions here in California. Most are still operating churches and almost all have gift shops selling it crucifixes, rosaries, saints images, books, and a large variety of similar items. I dont see any problem with that at all. My parish is the largest in our diocese. No gift shop, but Ill bet we almost have enough bodies to support a small gift shop. Id have no problem if we opened one on our campus