For me, the key is effectiveness. Many of Trump's battles are good, because they do change the narrative and open eyes. But in these feuds with McCain and George Conway, he doesn't reveal anything that his supporters don't already know.
I really like the idea that Trump is a fighter; I just wish he wouldn't get into so many fights!