“Likely someone will present a court challenge.”
GOA has already filed, and there is at least one other I can’t recall. I don’t think the federal courts really care about the law, however. They’ll rule however they want to rule and what the law says will not be part of their thought process.
The way I look at Trump’s philosophy on guns is that he’s a defender of the 2nd amendment and he has a CCL and is likely proficient with his handgun. But he’s not really a gun guy per se. More than likely he runs this stuff past Don Jr. Don probably told him the same thing I said. “Its the least thing you can do to stop the gun control talk”. So he did it.