John McCain is considered a war hero because he was awarded the Silver Star. The Silver Star Medal, is the third-highest military decoration for valor awarded to members of the United States Armed Forces. It is awarded for gallantry in action against an enemy of the United States.
A silver star, legion of merit with V device, and I believe 3 bronze stars...
That says nothing about his recent senatorial decisions, but he was in fact a hero.