Accumulating wealth is neither a sign of intelligence nor a guarantee of security. FWIW my parents did try to discourage me from smoking but they weren't neurotic control freaks so they let me make my own decisions once I reached the age of majority. If I had children I would do the same with them. I would particularly teach them not to make kneejerk judgments about other people and give them some insight into more important aspects of character and personality than peripheral lifestyle choices like smoking, food preferences or fashion choices. I would teach them to discern real character flaws such as the inability to judge people on an individual basis.
But it is idiotic to not also realize the common societal trends.
Smokers, as a group, are litterbugs. Glad you are not.
Smokers, as a group, are less wealthy. Which by any measure is not as good as being ABOVE the poverty line.
Smokers, as a group, are less educated. Dey ain't not got much o’ dat “book learning”.
Are there exceptions? Absolutely. Exceptional exceptions.
But as general good parenting - letting your child associate with groups whose behaviors predispose them to poverty and ignorance is not a good outcome.
“Don't get a grandson with a dog collar.” to quote a contemporaneous commercial.