Hoover was president only until 1933. FDR was president in 1939.
When I read that sentence, I thought the same thing you did. But Gerge Will put in the “ — “ meaning that we should skip from the “..federal spending” to the end of the sentence. The words between the two “—” is an insert.
You are correct that FDR was president in 1939.