Try to determine how many different songs you would actually want to listen to/have access to at any given time. That will help determine the size you need. Also, if you plan to store video on it, you'll need plenty of size. If you just want a basic mp3 player.
The 8 GB Sansa is nice. So are the Zen Vision products.