Actually, it works pretty well. My father-in-law became a US citizen by serving in the US Navy against the Japanese in WWII. He was so proud to be an American and raised his kids that way. If you wanted to assimilate a lot of folks fast (and turn them into conservative voters), that would be a really good way to do it.
It's one of the first things I have heard that I like about the bill.
Let's not blur the distinction between legal and illegal immigration.
I'm presuming that your father-in-law was a legal immigrant when he joined the Navy. Many legal immigrants have taken this route to citizenship and I have no problem with that whatsoever. I think that anyone who's willing to serve in the military should get a bump ahead of those who aren't willing to.
OTOH, I don't think that the opportunity to join the US military should be made available to illegal immigrants.
I agree. The US Military is the only effective socializing institution that hasn't been hollowed out and crippled by the leftwing termites and carpenter ants.