The Israeli wall has reduced suicide bombings by 97% and deaths caused by those terrorist attacks have been reduced by 99%. No wall or fence will work 100% of the time. But a barrier along the entire US-Mexico border will reduce border crossings significantly. I'd say in the 90%-95% range.
And I'd rather use those resourses to reduce terrorist attacks specifically, as opposed to all border crossings. It's called PRIORITIES.