this is one way to earn citizenship in the US. You have to be at least green card holder though. The military will not help you get permanent legal status so these are not illegals, just hard working legal immigrants to whom i say bravo.
Personally speaking, I was hoping to join after college to help with the war, but i have to wait at least 3 more years (when hopefully my green card application will be complete).
It probably would help recruitment if it were possible to long term legal residents to earn permanent residency as well whrough service.. they would certainly appreciate it more than the random people who just won the green card lottery (who can serve btw)
I see no problem with your suggestion. I have more respect for immigrants in our armed forces than I have for a significant percentage of our citizens.
BTW, nothing against legals who join.