Some good information on there, but there are a couple I've seen when reviewing records that aren't listed. A "General under honorable", is not considered a bad discharge. It usually means that for some reason (home emergency, injury not related to military service, etc.) the individual did not complete the terms of service, but that there was not a behavioral or disciplinary problem. Most employers have no problem with a general under honorable.
Other than honorable, is a huge black mark for the rest of your life. I strongly advise my people to go back and do anything, including getting a branch of the military to take them on as a reserve, to get any other than honorable changed.