Emoluments clause or not, I have a serious problem with any retired military officer or an elected official, who chooses to use that knowledge and experience to profit from aiding other countries, such as Russia and turkey. This is treasonous behavior, and people like this should be jailed or executed for selling out.
It’s a pretty long stretch to try to link it to the Emoluments Clause, ore even what you describe.
You miss my point, I do not care about the emoluments class as I think it is not applicable. What I do care about is that Flynn, a career military servicemember sold his experience and knowledge upon retiring to the Russians and Turks. I consider that treason and him a traitor. Shame on Trump and Pence for hiring him as they surely knew or should have known that he was at that point a foreign agent, a traitor.