Romans 5:3 says that suffering produces perseverance, which leads to a whole host of other character traits, but there’s NOTHING redemptive in suffering. God is not pleased by it.
It cannot be offered up to Him in hopes that it will get Him to hear us better and answer our prayers sooner. Nor does it impress Him with our ability to endure it.
Yes, there is a lot of bad theology about suffering.
God is pleased with Godly suffering. Moreover, martyr suffering MUST be evidence of faith, because of the beatitude in which Jesus says were blessed when we’re persecuted and have evil said about us for righteousness’ sake. for great is our reward in heaven. There are other similar verses that indicate that behaviour can indicate faith (or the lack thereof. )
As always, we must not throw out the baby with the bath water.