as long the discharge is “honorable” or even just “general under honorable conditions”, I don’t think there are serious adverse effects on employment, generally;
though certain government jobs or jobs with some government contractors may have some negative views of even a “general under honorable conditions” discharge;
and, I have no doubt that some employers ask only when someone was discharged and don’t even ask what kind of discharge was given - should they?, well you’d think so, but I think many don’t