McCain is a warrior most of the time. He's been a great ally of POTUS for the most part regarding the WOT and the NEED to win in Iraq.
He's just clueless about domestic policy.