I joined in 2006 (active-duty Army) and was told by my Drill Sergeant during Basic Training that we were all Veterans.
Well, times have changed. When I served it was pretty clear one was not a veteran until one separated from the military. Oh, one could be considered a veteran of an action or a battle, but that is a specific distinction. To me, a veteran is someone who has served and separated. For instance — and I don’t know how it is today — one would not qualify for veterans’ benefits through the VA until one separated from the military. At least, that’s how I remember it. Again, it’s been almost forty years since I separated.
I joined the USAF in 1956 and I am puking right now.