Would it be constitutional if the analysts were not Americans, and the analysis was provided to the US as foreign intelligence?
It would depend if the information was gathered from a US center or a foreign center. If the info was collected from a foreign source by foreign agents - there is no constitutional issue (the SC has no standing to order foreign governments to do anything so the question is irrelevant). However, if the data collection was occurring in the US, this would be illegal.